-
Notifications
You must be signed in to change notification settings - Fork 437
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ddtrace/opentelemetry: refactor OTel API tests #2503
Conversation
BenchmarksBenchmark execution time: 2024-01-25 17:36:08 Comparing candidate commit 8b46ec8 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 39 metrics, 2 unstable metrics. |
86c434c
to
365d936
Compare
365d936
to
eb4d2ea
Compare
eb4d2ea
to
e32ddc7
Compare
132a3e5
to
43a1231
Compare
983fd48
to
c18b43c
Compare
2e163f5
to
7f1897c
Compare
This is ready for re-review. I don't think I should approve it, since I wrote a lot of the commits. @dianashevchenko can you take a look at this when you get the chance? |
0a8fb1e
to
8b46ec8
Compare
Co-authored-by: Katie Hockman <katie.hockman@datadoghq.com> Co-authored-by: Dario Castañé <dario.castane@datadoghq.com>
What does this PR do?
GET
of URLs that aren't relevant to the testUses an atomic pointer to hold the payload in the trace writer to remove a data race(this has been removed)Motivation
This removes error logs (stemming from receiving an empty response) that otherwise can confuse someone trying to diagnose a bug into looking at the wrong problems.
This also addresses data corruption that happened if multiple concurrent accesses to the trace writer's payload happened (in particular in concurrency with
flush
).Reviewer's Checklist
For Datadog employees:
@DataDog/security-design-and-guidance
.Unsure? Have a question? Request a review!